update: CI_CD Docs#880
Conversation
1ada0f2 to
3cbbcb0
Compare
amaan-bhati
left a comment
There was a problem hiding this comment.
Hey @pathakharshit Thanks for raising this pr. A few things to fix before this can merge:
Blocking
The env variable reference in the YAML is wrong:
env:
KEPLOY_API_KEY: ${{ KEPLOY_API_KEY }}In GitHub Actions, secrets are accessed via the secrets context. It should be:
env:
KEPLOY_API_KEY: ${{ secrets.KEPLOY_API_KEY }}As written, this would silently pass an empty value and the workflow would fail with no clear error.
Structure issue
The section jumps straight to ### 2. Add the workflow with no ### 1.. The API key setup block (export KEPLOY_API_KEY="<API_KEY>") is floating above it without a heading.
Step 1 should walk the user through storing the key as a GitHub secret (repo Settings > Secrets and variables > Actions > New repository secret, name it KEPLOY_API_KEY). The export command is for local shell use, not CI - either remove it or clarify that distinction.
Incomplete workflow snippet
The text says "Create .github/workflows/keploy-cloud-replay.yml" which implies a full file, but the YAML block only contains jobs:. It is missing name: and on: triggers. Anyone copy-pasting this will get a broken workflow file. At minimum add:
name: Keploy Cloud Replay
on:
push:
branches: [main]
jobs:
keploy-cloud-replay:
...PR description
Please fill out the PR description. It still has the template placeholder text with none of the checkboxes checked. A one-liner on what this adds would work.
Happy to re-review once these are addressed.
Signed-off-by: Harshit Pathak <harshit07pathak@gmail.com>
Generalize the cloud replay section so it applies to any CI control plane (GitHub Actions, GitLab CI, Jenkins) and to both Keploy Cloud and self-hosted setups, remove the --trigger flag, and fix the API key secret reference (secrets.KEPLOY_API_KEY). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Harshit Pathak <harshit07pathak@gmail.com>
Add the "Running cloud replay in CI" section to gitlab.md and jenkins.md, matching the section already in github.md. Each file has a system-specific example (GitLab masked variable / Jenkins withCredentials) but the core flow is the same: set KEPLOY_API_KEY from the CI secret store, install the Enterprise binary, run keploy cloud replay. Works with both Keploy Cloud and self-hosted. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Harshit Pathak <harshit07pathak@gmail.com>
3cbbcb0 to
3df7219
Compare
Replace hardcode with hard-code and Jenkinsfile with Jenkins pipeline file to pass Vale spell check. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Harshit Pathak <harshit07pathak@gmail.com>
…ments - Remove duplicate Running cloud replay section that was stacked from two separate commits - Add name: and on: triggers to GitHub Actions YAML snippet so it is a complete, copy-pasteable workflow file - Consolidate steps with system-specific secret store instructions for GitHub Actions, GitLab CI, and Jenkins Fixes review comments from amaan-bhati. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Harshit Pathak <harshit07pathak@gmail.com>
amaan-bhati
left a comment
There was a problem hiding this comment.
Thanks for the updates @pathakharshit One thing to fix in the GitLab snippet before this can merge.
In gitlab.md, the keploy cloud replay command is split across multiple lines inside script: without shell \ continuation:
- keploy cloud replay
--app "<NAMESPACE>.<DEPLOYMENT>"
--cluster "<CLUSTER>"
--namespace "<NAMESPACE>"
--delay <DELAY>This relies on YAML plain scalar folding to join the lines before passing them to the shell, which technically works but is non-idiomatic. Anyone reading it will assume these are separate shell commands, and anyone editing it might add a \ thinking they need it - which would actually break it. The Jenkins example in this same PR does it correctly with \. Use the same approach here:
- |
keploy cloud replay \
--app "<NAMESPACE>.<DEPLOYMENT>" \
--cluster "<CLUSTER>" \
--namespace "<NAMESPACE>" \
--delay <DELAY>That aside, the rest looks good. Once addressed, please re request a review!
Use YAML block scalar (|) with backslash line continuations for the keploy cloud replay command, matching the Jenkins example style. The previous YAML plain scalar folding was non-idiomatic and misleading to readers. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Harshit Pathak <harshit07pathak@gmail.com>
Add a clear note that cloud replay re-runs test sets recorded from a Kubernetes deployment, not local or other recordings. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Harshit Pathak <harshit07pathak@gmail.com>

Summary
Adds a Running cloud replay in CI section to all three CI/CD docs (GitHub, GitLab, Jenkins).
Changes
github.md— new section with complete GitHub Actions workflow (name, on, jobs) and secrets.KEPLOY_API_KEYgitlab.md— new section with GitLab CI masked variable example, shell continuation with|and\jenkins.md— new section with Jenkins withCredentials exampleTest plan